Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @spapinistarkware)

crates/prover/src/constraint_framework/info.rs line 11 at r1 (raw file):

#[derive(Default)]
pub struct InfoEvaluator {

Document that this is used to collect the mask offsets and count the constraints for a specific component.

Code quote:

pub struct InfoEvaluator {

crates/prover/src/constraint_framework/info.rs line 30 at r1 (raw file):

        if self.mask_offsets.len() <= interaction {
            self.mask_offsets.resize(interaction + 1, vec![]);
        }

This code assumes that 'interaction` is continuous (which is true) but it may be called differently
Alternatively handle that differently

Suggestion:

        if self.mask_offsets.len() <= interaction {
            assert_eq(self.mask_offsets.len() == interaction + 1);
            self.mask_offsets.resize(interaction + 1, vec![]);
        }

crates/prover/src/constraint_framework/info.rs line 41 at r1 (raw file):

    }

    fn combine_ef(_values: [Self::F; 4]) -> Self::EF {

Fix

Suggestion:

    fn combine_ef(values: [Self::F; SECURE_EXTENSION_DEGREE]) -> Self::EF {

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)

crates/prover/src/constraint_framework/info.rs line 11 at r1 (raw file):

Done.

crates/prover/src/constraint_framework/info.rs line 30 at r1 (raw file):

As discussed.

crates/prover/src/constraint_framework/info.rs line 41 at r1 (raw file):

Done.

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)